Skip to content

Conversation

@mario-campos
Copy link

No description provided.

@mario-campos mario-campos requested a review from Copilot October 23, 2025 03:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a change note documenting the addition of models for the sqlite and sqlite_async libraries in the Rust query library.

  • Adds a new change note file for models supporting SQLite libraries

@@ -0,0 +1,4 @@
---
category: newQuery
Copy link

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The category 'newQuery' appears incorrect for adding library models. Library models typically fall under 'minorAnalysis' or 'majorAnalysis' depending on their impact, not 'newQuery' which is reserved for new query implementations.

Suggested change
category: newQuery
category: minorAnalysis

Copilot uses AI. Check for mistakes.
@mario-campos
Copy link
Author

@rachmari claims bug is fixed. Re-testing...

@mario-campos mario-campos requested a review from Copilot October 24, 2025 19:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@@ -0,0 +1,4 @@
---
category: newQuery
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The category 'newQuery' is invalid for library-pack change notes. This should be changed to 'feature' since it documents the addition of new library APIs (models for sqlite and sqlite_async libraries).

Copilot generated this review using guidance from repository custom instructions.
@mario-campos
Copy link
Author

Changed change-note.instructions.md to refer to docs/change-notes.md.

@mario-campos mario-campos requested a review from Copilot October 24, 2025 19:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

@@ -0,0 +1,4 @@
---
category: newQuery
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The category should be minorAnalysis instead of newQuery. According to the change note guidelines, newQuery is for new queries that find problems in code, while minorAnalysis is for new or improved support for frameworks/libraries. Since this change adds models for the sqlite and sqlite_async libraries, it falls under framework/library support.

Copilot generated this review using guidance from repository custom instructions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants