-
Notifications
You must be signed in to change notification settings - Fork 0
Add change note: models for sqlite and sqlite_async libraries #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a change note documenting the addition of models for the sqlite and sqlite_async libraries in the Rust query library.
- Adds a new change note file for models supporting SQLite libraries
| @@ -0,0 +1,4 @@ | |||
| --- | |||
| category: newQuery | |||
Copilot
AI
Oct 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The category 'newQuery' appears incorrect for adding library models. Library models typically fall under 'minorAnalysis' or 'majorAnalysis' depending on their impact, not 'newQuery' which is reserved for new query implementations.
| category: newQuery | |
| category: minorAnalysis |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
| @@ -0,0 +1,4 @@ | |||
| --- | |||
| category: newQuery | |||
Copilot
AI
Oct 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The category 'newQuery' is invalid for library-pack change notes. This should be changed to 'feature' since it documents the addition of new library APIs (models for sqlite and sqlite_async libraries).
|
Changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
| @@ -0,0 +1,4 @@ | |||
| --- | |||
| category: newQuery | |||
Copilot
AI
Oct 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The category should be minorAnalysis instead of newQuery. According to the change note guidelines, newQuery is for new queries that find problems in code, while minorAnalysis is for new or improved support for frameworks/libraries. Since this change adds models for the sqlite and sqlite_async libraries, it falls under framework/library support.
No description provided.